Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(text-input): Support CSS Variables in InputGroup #2935

Merged
merged 3 commits into from
Sep 24, 2024
Merged

feat(text-input): Support CSS Variables in InputGroup #2935

merged 3 commits into from
Sep 24, 2024

Conversation

NicholasBoll
Copy link
Member

Summary

Add support for the new Canvas tokens that utilize CSS Variables in InputGroup and export the maybeWrapCssVars function from the styling package.

Release Category

Components

Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

@NicholasBoll NicholasBoll added ready for review Code is ready for review 12.x labels Sep 24, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 24, 2024

Workday/canvas-kit    Run #7783

Run Properties:  status check passed Passed #7783  •  git commit ad86c0a8b3 ℹ️: Merge 62f3674c654cfa4ac7918f90274d40237c9f93a7 into 6f4f525aec6c1e3c5119667271d1...
Project Workday/canvas-kit
Branch Review feat/support-tokens-in-inputgroup
Run status status check passed Passed #7783
Run duration 03m 46s
Commit git commit ad86c0a8b3 ℹ️: Merge 62f3674c654cfa4ac7918f90274d40237c9f93a7 into 6f4f525aec6c1e3c5119667271d1...
Committer Nicholas Boll
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 27
Tests that did not run due to a developer annotating a test with .skip  Pending 16
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1097
View all changes introduced in this branch ↗︎
UI Coverage  21.92%
  Untested elements 1786  
  Tested elements 499  
Accessibility  99.09%
  Failed rules  5 critical   6 serious   0 moderate   2 minor
  Failed elements 458  

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels Sep 24, 2024
@alanbsmith alanbsmith merged commit f1fb499 into prerelease/major Sep 24, 2024
26 of 27 checks passed
@alanbsmith alanbsmith deleted the feat/support-tokens-in-inputgroup branch September 24, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mannycarrera4 mannycarrera4 mannycarrera4 approved these changes

@RayRedGoose RayRedGoose Awaiting requested review from RayRedGoose

Assignees
No one assigned
Labels
12.x automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasBoll @mannycarrera4 @alanbsmith