feat: Deprecated Table in Main #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunguyen19
force-pushed
the
deprecate-table
branch
from
f89fc30 to
0356305
Compare
1 flaky test on run #6190 ↗︎
Details:
|
|||||||||||||||
|
We should add this to our comms in |
thunguyen19
force-pushed
the
deprecate-table
branch
from
0356305 to
b59a8aa
Compare
| @@ -13,6 +13,8 @@ any questions. | |||
| - [useBanner](#useBanner) | |||
| - [Deprecations](#deprecations) | |||
| - [InputIconContainer](#input-icon-container) | |||
| - [Table](#table) | |||
| - [TableRow](#table-row) | |||
There was a problem hiding this comment.
You can probably just reference Table here and down below mention that all exported members or components are being deprecated
There was a problem hiding this comment.
Updated. Could you re-check?
thunguyen19
force-pushed
the
deprecate-table
branch
from
b59a8aa to
ce7c78b
Compare
mannycarrera4
approved these changes
Sep 25, 2023
mannycarrera4
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecate
Tablein main.Resolves: #2249
Release Category
Components
For the Reviewer
Where Should the Reviewer Start?
modules/react/table/lib/Table.tsxmodules/react/table/lib/TableRow.tsxmodules/docs/mdx/10.0-UPGRADE_GUIDE.mdx/.storybook/routes.js/is already updated with route to Table in Preview https://github.com/Workday/canvas-kit/blob/prerelease/major/.storybook/routes.js#L15