Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Render type parameters in external SymbolDoc symbols #2340

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

NicholasBoll
Copy link
Member

@NicholasBoll NicholasBoll commented Sep 18, 2023

Summary

The external SymbolDoc type did not render type parameters:

Record<string, number>

This fix updates the external symbol type to include the type parameters.

Release Category

Documentation


Checklist

  • Label ready for review has been added to PR

Screenshot

image

The external `SymbolDoc` type did not render type parameters:

```ts
Record<string, number>
```

This fix updates the external symbol type to include the type parameters.
@NicholasBoll NicholasBoll added the ready for review Code is ready for review label Sep 18, 2023
@cypress
Copy link

cypress bot commented Sep 18, 2023

Passing run #6160 ↗︎

0 799 2 0 Flakiness 0

Details:

Merge 64550bd into 76e356d...
Project: canvas-kit Commit: c5b6695ead ℹ️
Status: Passed Duration: 06:56 💡
Started: Sep 18, 2023 5:29 PM Ended: Sep 18, 2023 5:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@alanbsmith alanbsmith merged commit 734c8ab into support Sep 18, 2023
22 checks passed
@alanbsmith alanbsmith deleted the docs/external-type-parameters branch September 18, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ready for review Code is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants