Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add info to maintaining doc about deprecations #2339

Merged
merged 22 commits into from
Sep 26, 2023
Merged

docs: Add info to maintaining doc about deprecations #2339

merged 22 commits into from
Sep 26, 2023

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Sep 18, 2023 •
edited
Loading

Summary

Add docs to maintaining doc on how to deprecate components and utilities.

Release Category

Documentation

@cypress
Copy link

cypress bot commented Sep 18, 2023 •
edited
Loading

1 failed test on run #6222 ↗︎

1 940 2 0 Flakiness 0

Details:

Merge cee0da7 into 5ea37a8...
Project: canvas-kit Commit: 0323c433f6 ℹ️
Status: Failed Duration: 08:11 💡
Started: Sep 25, 2023 9:59 PM Ended: Sep 25, 2023 10:07 PM
Failed  cypress/integration/Autocomplete.spec.ts • 1 failed test

View Output Video

Test Artifacts
... > when a value is entered > when down arrow key is pressed > when the user presses the enter key > when the use hits the "2" key > should change the filtered results Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Sep 18, 2023
@github-actions github-actions bot requested a review from jamesfan September 18, 2023 17:13
@jamesfan jamesfan added review in progress Code is currently under review and removed ready for review Code is ready for review labels Sep 21, 2023
@mannycarrera4 mannycarrera4 added ready for review Code is ready for review and removed review in progress Code is currently under review labels Sep 25, 2023
jamesfan
jamesfan approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@jamesfan jamesfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work on this @mannycarrera4! Left all my suggestions above, let me know if you have any questions.

Everything else looks good. 👍

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels Sep 25, 2023
@alanbsmith alanbsmith enabled auto-merge (squash) September 25, 2023 21:54
@alanbsmith alanbsmith merged commit a35e993 into Workday:master Sep 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfan jamesfan jamesfan approved these changes

@josh-bagwell josh-bagwell Awaiting requested review from josh-bagwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mannycarrera4 @jamesfan @alanbsmith