fix(popup): Allow SVG elements in focus calculations #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVG elements should not be used as popup targets, but we shouldn't be restricting them. This change allows SVG elements to be valid elements when it comes to calculating focus returning and management in the popup system. Fixes #2330
alanbsmith
approved these changes
Sep 6, 2023
Passing run #6110 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
alanbsmith
added
accessibility
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SVG elements should not be used as popup targets, but we shouldn't be restricting them. This change allows SVG elements to be valid elements when it comes to calculating focus returning and management in the popup system.
Fixes #2330
Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer