Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF Enhancements for Select #2807

Closed
myvuuu opened this issue Jun 27, 2024 · 0 comments · Fixed by #2865
Closed

FF Enhancements for Select #2807

myvuuu opened this issue Jun 27, 2024 · 0 comments · Fixed by #2865
Assignees
@mannycarrera4
Labels
12.x
Milestone
12.0.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Jun 27, 2024 •
edited
Loading

🚀 Feature Proposal

Add the following enhancements to Select:

  • Enable padding adjustments within the input container
  • Create examples / recipes
  • Create tests

Motivation

Please outline the motivation for the proposal.

Example

Please provide an example for how this feature would be used.
@github-project-automation github-project-automation bot moved this to 🆕 New in Canvas Kit Jun 27, 2024
@myvuuu myvuuu changed the title Text and Padding Customization Enhancements for Select FF Enhancements for Select Jun 27, 2024
@myvuuu myvuuu added the 12.x label Jul 1, 2024
@myvuuu myvuuu moved this from 🆕 New to 🔖 Ready in Canvas Kit Jul 1, 2024
@myvuuu myvuuu added this to the 12.0.0 milestone Jul 1, 2024
@myvuuu myvuuu moved this from 🔖 Ready to 📨 On Deck in Canvas Kit Jul 2, 2024
@myvuuu myvuuu mentioned this issue Jul 18, 2024
Open
@myvuuu myvuuu moved this from 📨 On Deck to 📋 To Do in Canvas Kit Aug 14, 2024
@myvuuu myvuuu moved this from 📋 To Do to 🏗 In progress in Canvas Kit Aug 14, 2024
@mannycarrera4 mannycarrera4 mentioned this issue Aug 15, 2024
Merged
10 tasks
@jaclynjessup jaclynjessup linked a pull request Aug 22, 2024 that will close this issue
chore: Add FormFieldGroup component and density example #2865
Merged
10 tasks
alanbsmith pushed a commit that referenced this issue Sep 20, 2024
@mannycarrera4 @josh-bagwell @RayRedGoose
chore: Add FormFieldGroup component and density example (#2865)
87dbe31 
Fixes: #2805, #2806, #2820, [#2807](#2807)

[category:Components]

Release Note:
- We've added a new `FormFieldGroup` component to use when grouping inputs like checkboxes and radio inputs that need to be associated to one another. Its API matches the `FormField` API where you have `error` prop as well as `id` `isRequired` and `orienation`.

- `orientation` has been added back to `useFormFieldModel` to better support sub component styling.

- Styles have been cleaned up to use `gap` for proper spacing between labels, inputs and hint text.

- Added a new `FormField.Field` component to ensure proper alignment between label and inputs regardless of orientation and hint text. Ensure to wrap your inputs and hint text in this component.

Co-authored-by: manuel.carrera <[email protected]>
Co-authored-by: @josh-bagwell <[email protected]>
Co-authored-by: @RayRedGoose <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Canvas Kit Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mannycarrera4 mannycarrera4

Labels
12.x
Projects
Canvas Kit
Status: ✅ Done
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

chore: Add FormFieldGroup component and density example mannycarrera4/canvas-kit
2 participants
@mannycarrera4 @myvuuu