Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Replace h4 with h2 on settings modal titles #13

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

sejas
Copy link
Contributor

@sejas sejas commented Aug 24, 2023

Description

It changes the header level on modal settings for create-block/wasm-demo block.

Testing instructions

  • In a terminal run:
    • yarn install
    • composer install
    • yarn wp-env start # to start the main server
  • In a new terminal run:
    • cd source/wp-content/themes/wporg-wasm/src/wasm-demo
    • nvm use v14.21.3
    • yarn install
    • yarn start # to start the wasm demo block
  • Go to /wp-admin
  • Activate the Wasm theme if it's not active yet.
  • Create a new page
  • Embed the block wasm demo
  • View the forntend page
  • Click on the settings button
  • Inspect the titles Select a theme and Add plugins
  • Observe they are h2 instead of h4
  • I couldn't reproduce the issue with axe chrome extension

Screenshot

Before
Screenshot 2023-08-24 at 15 47 46

After
Screenshot 2023-08-24 at 15 48 09

Copy link

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work as expected and I could see h2 instead of h4:

Add plugins

Screenshot 2023-09-18 at 2 32 32 PM

Select a theme

Screenshot 2023-09-18 at 2 32 03 PM

@adamziel adamziel merged commit 2002179 into WordPress:main Sep 29, 2023
@sejas sejas deleted the update/header-levels-settings branch October 4, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WordPress Playground Demo: The Settings modal heading levels should only increase by one
3 participants