Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the print stylesheet throughout WordPress.org #158

Closed
ndiego opened this issue Sep 24, 2024 · 4 comments
Closed

Improve the print stylesheet throughout WordPress.org #158

ndiego opened this issue Sep 24, 2024 · 4 comments
Labels
[Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working

Comments

@ndiego
Copy link
Member

ndiego commented Sep 24, 2024

The print styles throughout WordPress.org (the sections powered by this parent theme) are pretty rough. It would be worthwhile to make some subtle improvements, much like WordPress/wporg-news-2021#427

@ndiego ndiego added [Type] Bug Something isn't working [Component] Theme Templates, patterns, CSS labels Sep 24, 2024
ryelle added a commit that referenced this issue Sep 26, 2024
ryelle added a commit to WordPress/wporg-main-2022 that referenced this issue Sep 26, 2024
This builds on the styles added in WordPress/wporg-parent-2021@0eda271, with styles specific to the home and about pages.

See WordPress/wporg-parent-2021#158
@ryelle
Copy link
Contributor

ryelle commented Sep 26, 2024

I've added a general print stylesheet for the network. I focused on the About & Download subpages (including release pages, which should cascade to all pages), documentation articles & developer handbook articles, code reference pages, and developer blog articles. I also added some specific styles to main for the w.org homepage and "About" page.

I also added a class, wporg__hide-on-print, which can be used to hide elements when printing.

A quick check shows that Five for the Future inherits styles nicely. The showcase & directories do too, but if we need to really support printing these they'll need a little more help.

Forums has a few glitches in printing (thread lists and individual posts), should that be updated too?

There's an extra step to deploy this out to Events since it's on the WordCamp infrastructure, so that's not quite right ATM. I'm following up on that.

Let me know if anything looks off, or if I should iterate on any other sections.

@ndiego
Copy link
Member Author

ndiego commented Sep 27, 2024

Thanks for all your work on this. The wporg__hide-on-print class is great. Then, we can use this in the Editor as needed.

Forums has a few glitches in printing (thread lists and individual posts), should that be updated too?

I don't think so. I cannot imagine people printing forum threads.

@ryelle
Copy link
Contributor

ryelle commented Sep 30, 2024

Do you think we can close this issue, or are there any places where the styles still need work?

@ndiego
Copy link
Member Author

ndiego commented Sep 30, 2024

Do you think we can close this issue, or are there any places where the styles still need work?

I did some spot checks and it looks really good, thanks @ryelle. I'll close this out, and if any other isolated issues pop up, we can address them separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants