Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stroke on category pages paginations #190

Merged
merged 6 commits into from
Jan 14, 2022
Merged

Fix stroke on category pages paginations #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1344b44
fix stroke colors on category pages
MaggieCabrera Jan 12, 2022
93c71ee
fixed query pagination markup
MaggieCabrera Jan 12, 2022
12b7028
refactor variables for stroke, centered on mobile
MaggieCabrera Jan 12, 2022
be2706b
fix stroke positioning
MaggieCabrera Jan 12, 2022
5620cd2
Remove stroke color property
ryelle Jan 13, 2022
6fbfe36
Fix the pagination styling on blog archives (`/page/2/` etc)
ryelle Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions source/wp-content/themes/wporg-news-2021/block-templates/category-community.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@
<!-- /wp:post-template -->

<!-- wp:query-pagination -->
<div class="wp-block-query-pagination">
<!-- wp:query-pagination-previous {"label":"Newer Posts"} /-->
<!-- wp:query-pagination-numbers /-->
<!-- wp:query-pagination-next {"label":"Older Posts"} /-->
</div>
<!-- /wp:query-pagination -->


Expand Down
2 changes: 0 additions & 2 deletions source/wp-content/themes/wporg-news-2021/block-templates/category-events.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
<!-- /wp:post-template -->

<!-- wp:query-pagination -->
<div class="wp-block-query-pagination">
<!-- wp:query-pagination-previous {"label":"Newer Posts"} /-->
<!-- wp:query-pagination-numbers /-->
<!-- wp:query-pagination-next {"label":"Older Posts"} /-->
</div>
<!-- /wp:query-pagination -->

</main>
Expand Down
2 changes: 0 additions & 2 deletions source/wp-content/themes/wporg-news-2021/block-templates/category-releases.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
<!-- /wp:post-template -->

<!-- wp:query-pagination -->
<div class="wp-block-query-pagination">
<!-- wp:query-pagination-previous {"label":"Newer Posts"} /-->
<!-- wp:query-pagination-numbers /-->
<!-- wp:query-pagination-next {"label":"Older Posts"} /-->
</div>
<!-- /wp:query-pagination -->
</main>
<!-- /wp:query -->
Expand Down
2 changes: 0 additions & 2 deletions source/wp-content/themes/wporg-news-2021/block-templates/category.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
<!-- /wp:post-template -->

<!-- wp:query-pagination -->
<div class="wp-block-query-pagination">
<!-- wp:query-pagination-previous {"label":"Newer Posts"} /-->
<!-- wp:query-pagination-numbers /-->
<!-- wp:query-pagination-next {"label":"Older Posts"} /-->
</div>
<!-- /wp:query-pagination -->

</main>
Expand Down
2 changes: 0 additions & 2 deletions source/wp-content/themes/wporg-news-2021/block-templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@
<!-- /wp:post-template -->

<!-- wp:query-pagination -->
<div class="wp-block-query-pagination">
<!-- wp:query-pagination-previous {"label":"Newer Posts"} /-->
<!-- wp:query-pagination-numbers /-->
<!-- wp:query-pagination-next {"label":"Older Posts"} /-->
</div>
<!-- /wp:query-pagination -->

</main>
Expand Down
17 changes: 17 additions & 0 deletions source/wp-content/themes/wporg-news-2021/sass/blocks/_query-pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,23 @@
color: var(--wp--preset--color--blue-1);
position: relative;

body:where(.archive, .blog.paged) & {
padding: 40px 0;

@include break-small-only() {
display: flex;
justify-content: center;

&::after {
mask-position: center;
}
}

&::after {
z-index: -1;
}
}

.wp-block-query-pagination-next {
z-index: 2;
}
Expand Down
8 changes: 7 additions & 1 deletion source/wp-content/themes/wporg-news-2021/sass/components/_categories.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ body.category-events {
}

body.category-releases {
--contrast-color: var(--wp--preset--color--blue-5);

.wp-site-blocks {
background-color: var(--wp--preset--color--blue-1);
}
Expand All @@ -31,7 +33,11 @@ body.category-releases {
}

.local-header {
--bar-background-color: var(--wp--preset--color--blue-5);
--bar-background-color: var(--contrast-color);
}

.wp-block-query-pagination::after {
background-color: var(--contrast-color);
}

@extend %footer-archive-dark;
Expand Down
8 changes: 7 additions & 1 deletion source/wp-content/themes/wporg-news-2021/sass/components/_local-header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,16 +244,22 @@

// Alternate off-white version.
%local-header-off-white {
--contrast-color: var(--wp--preset--color--white);

.wp-site-blocks {
background-color: var(--wp--preset--color--off-white);

.local-header {
--bar-background-color: var(--wp--preset--color--white);
--bar-background-color: var(--contrast-color);
--bar-text-color: var(--wp--preset--color--black);
--bar-link-color: var(--wp--preset--color--blue-1);
--bar-link-hover-color: var(--wp--preset--color--blue-1);
}
}

.wp-block-query-pagination::after {
background-color: var(--contrast-color);
}
}

// Alternate version with a color light enough to need dark text. e.g., Security category.
Expand Down