Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pagination from template-part to the main templates #179

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

tellyworth
Copy link
Contributor

It seems that query context isn't passed into template parts(!). This means that query-pagination blocks must be in the same template file as the query block or they won't work.

Related: WordPress/gutenberg#28011

Fixes (most of) #70.

It seems that query context isn't passed into template parts(!). This means that query-pagination blocks must be in the same template file as the query block or they won't work.

Related: WordPress/gutenberg#28011
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This WFM 👍🏻

It's unfortunate that we have to make things less DRY, but I added a reminder to fix that once the upstream issue is resolved

#58

@iandunn iandunn merged commit ac493cd into trunk Jan 12, 2022
@iandunn iandunn deleted the fix/buggy-pagination branch January 12, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants