-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an mu-plugin for tweaking the Stream plugin to meet our needs #172
Conversation
For now this replaces Stream's posts connector with our own modified version so that it will log post changes correctly when made in the block editor. Other tweaks may follow.
Can the custom posts connector extend the Stream one and just overwrite the minimal things needed? I'm concerned that any upstream fixes to the connector won't get applied to this class when needed.
I thought this was fixed via xwp/stream#1264 ? |
Is was, but that change hasn't made it into a version release yet 😕
Yeah, I guess that might be a better path in the short term, just to get the logging working. The posts connector is... lacking in other ways, so I figure we might replace it entirely, or at least big chunks of it, eventually. But that's probably a separate, bigger conversation. Let me go back and change it to a child class of the Stream one for now... |
Oh :/ It was merged moments after the 3.8.2 release I guess.. @kasparsd Any chance of getting Stream master merged to plugins.svn trunk? or releasing a new version? |
^ Ok, simplified it to a child class that only overrides the one property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this with Stream 3.8.2 locally, and it captures patterns created from the frontend, and changes made in the wp-admin block editor. I think we should merge this, and if/when Stream updates we can remove it.
I've tagged Stream 3.9.0 a few moments ago which now includes the fix that was merged a while ago. There was an issue with unit tests which took me a bit longer to resolve. |
Thank you @kasparsd ! |
For now this replaces Stream's posts connector with our own modified version so that it will log post changes correctly when made in the block editor. Other tweaks may follow.
This will help WordPress/pattern-directory#57 move forward.