Renamed the param opfs-browser from Query API, to browser #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added startupOptions.storage === 'browser'
Added config.storage === 'browser'
Added config.storage === 'browser'
Changed opfs-browser param by browser
Changed opfs-browser param by browser
marcarmengou
changed the title
|
Thank you so much @marcarmengou! It's nearly there, here's a few more places to update – feel free to just replace |
adamziel
reviewed
Oct 5, 2023
packages/playground/website/src/components/playground-configuration-group/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Zielinski <[email protected]>
|
Done. Thanks @adamziel! |
|
Looks great, thank you @marcarmengou! |
adamziel
pushed a commit
that referenced
this pull request
Oct 10, 2023
## What is this PR doing? Changed the param 'opfs-browser' to 'browser' as discussed at: #636 Kept the old names working, for now. ## What problem does it solve? Renamed the opfs-browser parameter to simply browser, to make it easier for users to remember.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Changed the param 'opfs-browser' to 'browser' as discussed at: #636
Kept the old names working, for now.
What problem does it solve?
Renamed the opfs-browser parameter to simply browser, to make it easier for users to remember.