OPFS: Migrate to the latest spec #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
adamziel
commented
Jun 14, 2023
Comment on lines
+18
to
+19
| const zipName = 'wordpress-playground.zip'; | ||
| const zipPath = `/tmp/${zipName}`; |
There was a problem hiding this comment.
This is somewhat unrelated but I found Safari refused to download the exported file without this
|
Do we have a clear and easy reset button to click on to wipe out everything? |
|
Yup, that's a necessary feature. I don't love the crowded toolbar – it could use some iterating 
|
adamziel
added a commit
that referenced
this pull request
Jun 14, 2023
Since #547 adds support for OPFS API, I just realized the same API can be used to read/write local files. This PR adds a local directory picker and a "refresh" button to bring the changes back into Playground's MEMFS. The Toolbar is getting really crowded, let's add a hamburger menu for now before merging this PR. In the future, let's find out a better UI solution than a hamburger menu.
This was referenced Jun 14, 2023
Previous implementation of OPFS sync used deprecated webkitRequestFileSystem and only worked in Chrome-based browser. This commit migrates to the modern FileSystem API which means it can be also used on Safari, Firefox, and more: https://developer.mozilla.org/en-US/docs/Web/API/File_System_Access_API
…o switch to a temporary site or nuke everything if needed.
adamziel
force-pushed
the
use-latest-filesystem-api-spec
branch
from
16ebe4d to
1fa4f00
Compare
adamziel
force-pushed
the
use-latest-filesystem-api-spec
branch
from
1fa4f00 to
bbda40c
Compare
adamziel
force-pushed
the
use-latest-filesystem-api-spec
branch
from
b19c3a1 to
163afe7
Compare
|
@adamziel considering the "Install Plugins UI" makes me think about a ⚙️ settings icon in the top right. open that and you pick all these things. could be a good model for all these settings. |
|
@dmsnell we have this now – it should be a good platform for future iterations: 
I avoided a single unlabeled settings icon because:
|
adamziel
added a commit
that referenced
this pull request
Jun 22, 2023
Since #547 adds support for OPFS API, I just realized the same API can be used to read/write local files. This PR adds a local directory picker and a "Sync local files" button to bring the changes back into Playground's MEMFS.
Pookie717
added a commit
to Pookie717/wordpress-playground
that referenced
this pull request
Oct 1, 2023
Since WordPress/wordpress-playground#547 adds support for OPFS API, I just realized the same API can be used to read/write local files. This PR adds a local directory picker and a "Sync local files" button to bring the changes back into Playground's MEMFS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous implementation of OPFS sync used deprecated webkitRequestFileSystem and only worked in Chrome-based browser.
This commit migrates to the modern FileSystem API which means it can be also used on Safari, Firefox, and mobile:
https://developer.mozilla.org/en-US/docs/Web/API/File_System_Access_API
Testing Instructions
Select "Persistent site" in the mode picker and confirm your changes are preserved between page refreshes:
cc @dmsnell