Blueprints: Use the major WordPress version to download RC/beta translations #2017
+62
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lations Uses a major WordPress version to fetch the translations, e.g. https://downloads.wordpress.org/translation/core/6.6-RC/en_US.zip instead of https://downloads.wordpress.org/translation/core/6.6.1-RC/en_US.zip This fixes an issue introduced in #1987 that caused the E2E tests to fail on trunk: ``` ✘ 77 [chromium] › blueprints.spec.ts:438:6 › should translate WP-admin to Spanish for the beta WordPress build (retry #3) (30.2s) ``` The setSiteLanguage step would try to download the translations from https://downloads.wordpress.org/translation/core/6.7.1-RC/es_ES.zip which responded with a 404, instead of https://downloads.wordpress.org/translation/core/6.7-RC/es_ES.zip where the translations are actually available. ## Testing instructions * Confirm the E2E tests pass * Go here and confirm you can see a Spanish version of wp admin: http://localhost:5400/website-server/?language=es_ES&url=%2Fwp-admin%2F&wp=beta&modal=error-report
adamziel
added
[Type] Bug
adamziel
deleted the
use-a-major-version-when-fetching-beta-rc-translations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a major WordPress version to fetch the translations, e.g.
https://downloads.wordpress.org/translation/core/6.6-RC/en_US.zipinstead ofhttps://downloads.wordpress.org/translation/core/6.6.1-RC/en_US.zipThis fixes an issue introduced in #1987 that caused the E2E tests to fail on trunk:
The setSiteLanguage step would try to download the translations from
https://downloads.wordpress.org/translation/core/6.7.1-RC/es_ES.zip
which responded with a 404, instead of
https://downloads.wordpress.org/translation/core/6.7-RC/es_ES.zip
where the translations are actually available.
Testing instructions