-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PWA support #1086
Add PWA support #1086
Conversation
"name": "WordPress Playground", | ||
"icons": [ | ||
{ | ||
"src": "/website-server/logo-192.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path only works on the local dev server. In production it will be just /logo-192.png
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a separate production manifest with the correct URL 21558f7
Once we have offline support, maybe we could use it in the browser extension instead of shipping WordPress and PHP in the |
That path needs to be updated, but I'm approving otherwise. |
Nice! I love being able to address Playground like a desktop app. It might even be cool to have the option to open all playground.wordpress.net links within/as the PWA. (I'm not sure whether there are defaults and options for this kind of behavior) |
I'm curious, how would this work? |
Motivation for the change, related issues
We want to make Playground available offline.
This PR is a first step and adds support for installing Playground as a PWA. Offline support will be implemented separately.
Implementation details
The PR adds a
manifest.json
file and loads it on the Playground website. This allows browsers to install Playground as a PWATesting Instructions (or ideally a Blueprint)