Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA support #1086

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Add PWA support #1086

merged 9 commits into from
Jun 12, 2024

Conversation

bgrgicak
Copy link
Collaborator

@bgrgicak bgrgicak commented Mar 5, 2024

Motivation for the change, related issues

We want to make Playground available offline.
This PR is a first step and adds support for installing Playground as a PWA. Offline support will be implemented separately.

Implementation details

The PR adds a manifest.json file and loads it on the Playground website. This allows browsers to install Playground as a PWA

Testing Instructions (or ideally a Blueprint)

@bgrgicak bgrgicak self-assigned this Mar 5, 2024
@bgrgicak bgrgicak added the [Type] Enhancement New feature or request label Mar 5, 2024
@bgrgicak bgrgicak mentioned this pull request Mar 5, 2024
@bgrgicak bgrgicak marked this pull request as ready for review June 5, 2024 11:36
@bgrgicak bgrgicak requested a review from a team as a code owner June 5, 2024 11:36
@bgrgicak bgrgicak marked this pull request as draft June 5, 2024 11:36
@bgrgicak bgrgicak marked this pull request as ready for review June 6, 2024 04:25
"name": "WordPress Playground",
"icons": [
{
"src": "/website-server/logo-192.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path only works on the local dev server. In production it will be just /logo-192.png.

Copy link
Collaborator Author

@bgrgicak bgrgicak Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a separate production manifest with the correct URL 21558f7

@adamziel
Copy link
Collaborator

Nice:

CleanShot 2024-06-11 at 12 52 27@2x

@adamziel
Copy link
Collaborator

Once we have offline support, maybe we could use it in the browser extension instead of shipping WordPress and PHP in the .crx bundle.

@adamziel
Copy link
Collaborator

That path needs to be updated, but I'm approving otherwise.

@brandonpayton
Copy link
Member

Nice! I love being able to address Playground like a desktop app.

It might even be cool to have the option to open all playground.wordpress.net links within/as the PWA. (I'm not sure whether there are defaults and options for this kind of behavior)

@bgrgicak bgrgicak merged commit ff955c1 into trunk Jun 12, 2024
5 checks passed
@bgrgicak bgrgicak deleted the add/pwa-support branch June 12, 2024 16:03
@bgrgicak
Copy link
Collaborator Author

It might even be cool to have the option to open all playground.wordpress.net links within/as the PWA. (I'm not sure whether there are defaults and options for this kind of behavior)

I'm curious, how would this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants