Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress Playground Demo: The iframe must have an accessible name #614

Closed
Tracked by #612
danielbachhuber opened this issue Jul 31, 2023 · 4 comments
Closed
Tracked by #612

WordPress Playground Demo: The iframe must have an accessible name #614

danielbachhuber opened this issue Jul 31, 2023 · 4 comments

Comments

@danielbachhuber
Copy link
Member

No description provided.

@danielbachhuber danielbachhuber mentioned this issue Jul 31, 2023
Closed
10 tasks
@jonathanbossenger
Copy link
Collaborator

iframe

Element:

<iframe id="wp" sandbox="allow-same-origin allow-scripts allow-popups allow-forms allow-downloads" src="https://wasm.wordpress.net/scope:0.9690524138984691/"></iframe>

According to axe DevTools, this problem can be solved by need to fixing at least one (1) of the following issues:

  • Element has no title attribute
  • aria-label attribute does not exist or is empty
  • aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  • Element's default semantics were not overridden with role="none" or role="presentation"

@dmsnell
Copy link
Member

dmsnell commented Aug 4, 2023

@jonathanbossenger I don't think this content is generated from within this repository, but I'm not sure from where it is. I think we need to find where the code is for the developer.wordpress.org/playground/demo is and then address the issues there.

@sejas
Copy link
Collaborator

sejas commented Aug 24, 2023

This iframe is inside the WordPress iframe. It seems to be something in "core" and not in https://github.com/wordpress/wporg-wasm

I was able to create a PR that fixes some of the other issues :

adamziel added a commit that referenced this issue Oct 5, 2023
@adamziel
Accessibility: Accessible iframe names
0a30dd5 
Solves #614 by assigning an accessible title to both iframes used in
WordPress Playground. To test, use Axe devtools as described in
#614 (comment)
This was referenced Oct 5, 2023
Merged
Merged
adamziel added a commit that referenced this issue Oct 5, 2023
@adamziel
Accessibility: Accessible iframe names (#657)
55a6c98 
Solves #614 by assigning an accessible title to both iframes used in
WordPress Playground. To test, use Axe devtools as described in
#614 (comment)
@adamziel
Copy link
Collaborator

adamziel commented Oct 5, 2023

Solved in #657

@adamziel adamziel closed this as completed Oct 5, 2023
adamziel added a commit that referenced this issue Oct 5, 2023
@adamziel
Accessibility: Give the URL input a title (#658)
e76e6d2 
Solves an accessibility problem where the URL input has no label/
description.

To test, install axe devTools and scan the local Playground site.

Related to #614
adamziel added a commit that referenced this issue Oct 10, 2023
@adamziel
Accessibility: Accessible iframe names (#657)
50854ba 
Solves #614 by assigning an accessible title to both iframes used in
WordPress Playground. To test, use Axe devtools as described in
#614 (comment)
adamziel added a commit that referenced this issue Oct 10, 2023
@adamziel
Accessibility: Give the URL input a title (#658)
3d02eb5 
Solves an accessibility problem where the URL input has no label/
description.

To test, install axe devTools and scan the local Playground site.

Related to #614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@danielbachhuber @jonathanbossenger @adamziel @sejas @dmsnell