Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writingMode support in dynamic blocks #7534

Conversation

andrewserong
Copy link
Contributor

Add writingMode to the style engine, to support dynamic blocks. This backports some PHP changes that were missed in previous WP core releases:

For the issue this resolves, see: WordPress/gutenberg#65910

Trac ticket: https://core.trac.wordpress.org/ticket/62189

This PR adds support for the writing mode (orientation) typography block support for dynamic blocks, such as the Site Title block. Without this change, currently (in WP 6.7 Beta 1 and Beta 2) if you go to update the Site Title block and give it a vertical orientation, it'll look fine within the site editor, but still display as horizontal on the site frontend.

To test this PR, open up the site editor, select the site title block, and switch its text orientation in the block inspector to be vertical. Save the template, and view the site frontend. Here is a quick screenshot to show where to update the text orientation (writing mode):

image


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Oct 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props andrewserong, wildworks, aaronrobertshaw.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Oct 8, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix 👍

Copy link

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @andrewserong 👍

This tests well for me:

Screenshot 2024-10-08 at 4 21 31 pm

I only have a minor question around whether we need a @since comment at all for this one in the docblock.

@andrewserong
Copy link
Contributor Author

Thanks for the reviews, everyone! 🙇

Committed in r59199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants