-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package-lock lockfile version #7526
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sirreal!
This makes sense to me, but we need a Trac ticket to attach it to. I was going to use Core-61530, but that's more for test tooling and test improvements. I think a separate ticket for this would be fine. Feel free to assign the ticket to me in Trac!
If you could create that, add it to this description to link the two, and make any necessary adjustments after the beta 2 package bumps, I can get this committed.
I had similar thinking, thanks for confirming. I've created #62190. |
I've merged trunk and then went through the process of resetting the lockfile and applying the version change again to ensure it's up to date. |
Update the package-lock.json file to the v3 format:
Given the engines and engine-strict setting, npm versions earlier than 7 should not be used and there should be no downsides to this change:
wordpress-develop/package.json
Lines 9 to 12 in 90d2429
wordpress-develop/.npmrc
Line 2 in 90d2429
Similar PR for Gutenberg: WordPress/gutenberg#65923
The lockfile goes from
2124789
to1175664
bytes, around 950kb smaller.Trac ticket: https://core.trac.wordpress.org/ticket/62190
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.