Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock lockfile version #7526

Closed

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Oct 7, 2024

Update the package-lock.json file to the v3 format:

3: Only the new lockfile information introduced in npm version 7. Smaller on disk than lockfile version 2, but not interoperable with older npm versions. Ideal if all users are on npm version 7 and higher.

Given the engines and engine-strict setting, npm versions earlier than 7 should not be used and there should be no downsides to this change:

"engines": {
"node": ">=20.10.0",
"npm": ">=10.2.3"
},

engine-strict = true

Similar PR for Gutenberg: WordPress/gutenberg#65923

The lockfile goes from 2124789 to 1175664 bytes, around 950kb smaller.

Trac ticket: https://core.trac.wordpress.org/ticket/62190


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Oct 7, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal sirreal marked this pull request as ready for review October 7, 2024 17:29
Copy link

github-actions bot commented Oct 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj self-requested a review October 8, 2024 00:16
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sirreal!

This makes sense to me, but we need a Trac ticket to attach it to. I was going to use Core-61530, but that's more for test tooling and test improvements. I think a separate ticket for this would be fine. Feel free to assign the ticket to me in Trac!

If you could create that, add it to this description to link the two, and make any necessary adjustments after the beta 2 package bumps, I can get this committed.

@sirreal
Copy link
Member Author

sirreal commented Oct 8, 2024

I was going to use Core-61530, but that's more for test tooling and test improvements. I think a separate ticket for this would be fine.

I had similar thinking, thanks for confirming. I've created #62190.

@sirreal
Copy link
Member Author

sirreal commented Oct 8, 2024

I've merged trunk and then went through the process of resetting the lockfile and applying the version change again to ensure it's up to date.

@sirreal sirreal requested a review from desrosj October 8, 2024 08:15
@desrosj
Copy link
Contributor

desrosj commented Oct 10, 2024

@desrosj desrosj closed this Oct 10, 2024
@sirreal sirreal deleted the update-package-lockfile-version branch October 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants