Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce specificity of global styles and layout selectors. #6522

Conversation

tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented May 8, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/61165

Syncs changes from WordPress/gutenberg#60106, WordPress/gutenberg#60228 and WordPress/gutenberg#61340.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@tellthemachines
Copy link
Contributor Author

Just realised that changes from #6489 are likely to conflict with these, especially the test string updates, so I might hold off on updating this one until #6489 is committed.

Copy link

github-actions bot commented May 8, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@tellthemachines tellthemachines force-pushed the add/global-styles-specificity-reduction branch from f265042 to 5f4cddb Compare May 9, 2024 04:47
@tellthemachines
Copy link
Contributor Author

PHP tests are updated, so marking this ready for review!

@tellthemachines tellthemachines marked this pull request as ready for review May 10, 2024 07:05
Copy link

github-actions bot commented May 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props isabel_brison, aaronrobertshaw.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronrobertshaw
Copy link

There are some proposed changes to specificity in WordPress/gutenberg#61638 and a general consensus to proceed with those changes for WP6.6.

Given the tight timeline until the 6.6 beta I've put together a separate draft PR bringing together all the specificity changes from the following PRs:

Once they settle that could be rolled into this PR or the core ticket updated to point to the alternate backport.

@tellthemachines
Copy link
Contributor Author

Closing in favour of #6633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants