Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Undefined array key attrs warning. #5326

Closed
wants to merge 1 commit into from

Conversation

mukeshpanchal27
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/59468


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@kafleg
Copy link
Member

kafleg commented Sep 27, 2023

This PR works fine. I am not able to see the Warning now.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review September 27, 2023 04:52
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to reproduce the original issue, but code change LGTM! It's a good idea as a general principle to expect array keys to not exist 😄

@tellthemachines
Copy link
Contributor

Committed in r56731.

@andrewserong
Copy link
Contributor

Thanks for fixing this up, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants