Don't add root padding to children of flex and grid layout blocks. #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
andrewserong
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Looks good to me on the site frontend!
Before
On trunk, the children of full width flex layouts (Row block) receive the root left/right padding:
After
With this PR, they do not:
The children of Group block in both cases still continue to receive the root padding left/right rules as expected.
LGTM! ✨
|
Also tests well for me. Thank you! |
|
Committed in r56546. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59295
Syncs the changes to
class-wp-theme-jsonfrom WordPress/gutenberg#53259, as well as a test string update.This one can be tested in the front end by following the steps detailed in WordPress/gutenberg#53259.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.