Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kses support for repeat #4637

Closed

Conversation

tellthemachines
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/58551

Adds support for the CSS repeat function.

The Trac ticket mentions support for auto-fit and -fill, but in testing I realised those are already implicitly supported so no changes needed there.

To test this change in the front end, apply the patch on top of #4625 and follow testing steps from that PR.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@azaozz
Copy link
Contributor

azaozz commented Jun 19, 2023

Support for repeat LGTM. Not sure about the removal of the aria-* attributes (seems like a typo/accidental)?

@tellthemachines
Copy link
Contributor Author

tellthemachines commented Jun 20, 2023

Not sure about the removal of the aria-* attributes (seems like a typo/accidental)?

Definitely accidental! I wonder how it happened, I didn't edit those lines manually 🤔

Update: the changeset that added those lines was committed yesterday and my branch didn't have it yet. All the same, I wouldn't have expected that to happen.

Anyway, it's now fixed! Thanks for noticing 😄

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion to cover my paranoia.

tests/phpunit/tests/kses.php Show resolved Hide resolved
@peterwilsoncc
Copy link
Contributor

Committed in r55944 / 2b7f865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants