Fluid typography: use layout.wideSize as max viewport width #4604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use the value of
settings.layout.wideSize
, if set, as the maximum viewport width for fluid font size calculations.The default value is
1600px
.Checks against invalid
settings.layout.wideSize
values to ensure resulting clamp values are calculated correctly. This is s defensive measure to prevent bugs.Added to the Gutenberg plugin in:
❗ If #4605 is merged first, this PR will need a rebase and possibly the tests updated
Testing
Note: this will only work on the frontend. The editor JS changes will be ready once WordPress/gutenberg#51516 is bundled with the npm packages destined for Core
npm run test:php -- --filter Tests_Block_Supports_Typography
Trac ticket: https://core.trac.wordpress.org/ticket/58522
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.