mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance issue #3609
Closed
Closed
Fix performance issue #3609
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8c9ecf3
Fix performance issue
spacedmonkey 25196f9
Merge branch 'trunk' into fix/57077
spacedmonkey 1946f71
Merge branch 'trunk' into fix/57077
spacedmonkey 0e14274
Also change `_add_block_template_part_area_info`.
spacedmonkey 0a10f50
Merge branch 'trunk' into fix/57077
spacedmonkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -351,7 +351,8 @@ function _add_block_template_info( $template_item ) { | |
return $template_item; | ||
} | ||
|
||
$theme_data = WP_Theme_JSON_Resolver::get_theme_data()->get_custom_templates(); | ||
$theme_data = WP_Theme_JSON_Resolver::get_theme_data( array(), array( 'with_supports' => false ) )->get_custom_templates(); | ||
|
||
if ( isset( $theme_data[ $template_item['slug'] ] ) ) { | ||
$template_item['title'] = $theme_data[ $template_item['slug'] ]['title']; | ||
$template_item['postTypes'] = $theme_data[ $template_item['slug'] ]['postTypes']; | ||
|
@@ -371,7 +372,7 @@ function _add_block_template_info( $template_item ) { | |
*/ | ||
function _add_block_template_part_area_info( $template_info ) { | ||
if ( WP_Theme_JSON_Resolver::theme_has_support() ) { | ||
$theme_data = WP_Theme_JSON_Resolver::get_theme_data()->get_template_parts(); | ||
$theme_data = WP_Theme_JSON_Resolver::get_theme_data( array(), array( 'with_supports' => false ) )->get_template_parts(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @SergeyBiryukov This works well! |
||
} | ||
|
||
if ( isset( $theme_data[ $template_info['slug'] ]['area'] ) ) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixarntz @desrosj @peterwilsoncc This work, because, supports are not needed here. You just need a WP_Theme_Json object. Adding these params, means that it hits a cache that it would not before. This function is called 300+ times a page load, there some serious savings here.