Fix TwentyTwenty font sizes & colors #2130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For themes without theme.json support we only enqueue the default styles provided by WordPress, such as the preset classes (font sizes, colors, etc). These should be always present as they may be used by old content and patterns. For themes with theme.json support, we also enqueue the theme styles.
To set the value of the WordPress core clasess we should set the corresponding CSS Custom Property of the font size.
oandregal
changed the title
jorgefilipecosta
approved these changes
Jan 10, 2022
|
Merged as of 2aff2a6 |
This was referenced Jan 11, 2022
pento
pushed a commit
that referenced
this pull request
Sep 9, 2023
…nts. Note: This is enforced by WPCS 3.0.0: 1. There should be no space between an increment/decrement operator and the variable it applies to. 2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around. References: * [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators] * [WordPress/WordPress-Coding-Standards#2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators] Props jrf. See #59161, #58831. git-svn-id: https://develop.svn.wordpress.org/trunk@56549 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket https://core.trac.wordpress.org/ticket/54782
Depends on #2129 and https://core.trac.wordpress.org/ticket/54781
How to test
Font sizes
smallto the 1st paragraph,normalto the 2nd, nothing to the third,largeto the 4th, andlargerto the 5th.The expected result is that the font size for each paragraph has the assigned value, both in the editor and front-end.
Colors
has-white-background-color has-black-colorinto the "Additional classes" text field of the "Advanced" section of the block sidebar.has-black-background-color has-white-colorinto the "Additional classes" text field of the "Advanced" section of the block sidebar.Via the browser devtools make sure that the first paragraph's color is
rgb(0,0,0)and its background isrgb(255,255,255). The second paragraph should be the opposite.