Change Requests class names to the correct case. #2001
Conversation
costdev
changed the title
WpOrg\Requests\Proxy\HTTP to the correct case.
There was a problem hiding this comment.
@costdev Requests files are a dependency where Core is a consumer of it, but not a maintainer. Needed changes for any of the Requests code should be reported to Requests repo via opening an issue https://github.com/WordPress/Requests/issues.
As these changes are docblocks and not sourcecode, I'd suggest removing those particular changes from this PR.
The change that fixes the fatal error reported in the Trac ticket is in src/wp-includes/Requests/Proxy/Http.php. This fix looks good to me 👍 and is a Core maintained file.
These files are not maintained in Core, but rather in the Requests repo.
| @@ -90,7 +90,6 @@ public static function uncompress($ip) { | |||
| * Example: FF01:0:0:0:0:0:0:101 -> FF01::101 | |||
| * 0:0:0:0:0:0:0:1 -> ::1 | |||
| * | |||
| * @see \WpOrg\Requests\IPv6::uncompress() | |||
There was a problem hiding this comment.
| * @see \WpOrg\Requests\IPv6::uncompress() | |
| * @see \WpOrg\Requests\IPv6::uncompress() |
Whoops didn't mean to remove the original comment. Doh.
|
Committed fix only (without docblock changes) in changeset https://core.trac.wordpress.org/changeset/52315. |
Discovered by and props to costdev via WordPress/wordpress-develop#2001 Co-authored-by: costdev <[email protected]>
This PR changes:
WpOrg\Requests\Proxy\HTTPtoWpOrg\Requests\Proxy\Http.WpOrg\Requests\IPv6toWpOrg\Requests\Ipv6.WpOrg\Requests\IRItoWpOrg\Requests\Iri.Trac ticket: https://core.trac.wordpress.org/ticket/54562