Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the WordPress packages to the versions in Gutenberg 11.9 RC #1827

Closed

Conversation

youknowriad
Copy link
Contributor

This is a subpart of #1804

It's an attempt to try a patch that only contains the minimum required changes for the packages update which should hopefully unblock other patches (FSE infrastructure for instance).

@youknowriad youknowriad force-pushed the update/packages-11-9-RC branch from 88a7927 to 5e70569 Compare November 8, 2021 08:21
@youknowriad
Copy link
Contributor Author

This is lacking two things to be ready to merge:

  • The default-editor-styles.css is required for the tests to pass without errors, this file comes with a npm run build but php tests right now are run without the build step. We could account for this in the runtime code but it sounds weird to adapt runtime code to tests.
  • The source map error when running npm run build. I'm not sure about this error, we could potentially ignore the failing file for now but I wonder if it highlights a bug in Gutenberg itself and whether we should have a similar check in the plugin as well.

@noisysocks
Copy link
Member

It's an attempt to try a patch that only contains the minimum required changes for the packages update which should hopefully unblock other patches (FSE infrastructure for instance).

Good idea 🙂

The default-editor-styles.css is required for the tests to pass without errors, this file comes with a npm run build but php tests right now are run without the build step. We could account for this in the runtime code but it sounds weird to adapt runtime code to tests.

I don't think it's wrong to add a runtime check. We need to support running WordPress from the src directory with no build files.

The source map error when running npm run build. I'm not sure about this error, we could potentially ignore the failing file for now but I wonder if it highlights a bug in Gutenberg itself and whether we should have a similar check in the plugin as well.

Also not sure about this. Let's leave it commented out in Gruntfile.js. I'll make a note to come back to this. Probably you are right that there's a bug in Gutenberg's build config.

@noisysocks noisysocks force-pushed the update/packages-11-9-RC branch from a729694 to c440290 Compare November 8, 2021 11:28
@noisysocks noisysocks changed the base branch from trunk to master November 8, 2021 11:29
@desrosj desrosj changed the base branch from master to trunk November 8, 2021 13:40
@desrosj
Copy link
Contributor

desrosj commented Nov 8, 2021

I've changed the base of this PR to trunk. This is now the default branch going forward. See the original proposal that is finally being put in place.

@youknowriad youknowriad closed this Nov 8, 2021
@youknowriad youknowriad deleted the update/packages-11-9-RC branch November 8, 2021 15:36
@ockham ockham mentioned this pull request Nov 8, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants