Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages with fixes for WP 5.8 beta 4 #1430

Closed

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jun 24, 2021

This includes the fixes in this PR WordPress/gutenberg#32956 and WordPress/gutenberg#32992

  • Update patterns to remove the "main" element. @ryelle
  • Update the webpack config to load the "view" script for the File block. @gziolo

Trac ticket https://core.trac.wordpress.org/ticket/53397

@gziolo
Copy link
Member

gziolo commented Jun 25, 2021

Update the webpack config to load the "view" script for the File block. @gziolo

I have a patch ready in the Gutenberg plugin WordPress/gutenberg#32977 that will require publishing to npm. Once it is available to npm, we can clean up #1412 and merge it with this branch.

Maybe it's better to land this branch first and tackle #1412 separately?

Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good to me. Haven't tested, but I'm sure these were tested enough in the plugin. 👍🏼

@youknowriad youknowriad deleted the update/packages-beta4-58 branch June 25, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants