Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Try filtering by show_in_nav_menus for post types and taxonomies #1002

Closed
wants to merge 1 commit into from

Conversation

gwwar
Copy link

@gwwar gwwar commented Feb 12, 2021

WIP Part of WordPress/gutenberg#24814 this PR experiments with allowing post types and taxonomies to be filtered by show_in_nav_menus. This will be used to help build the navigation/menu flows.

Experiments with if we need to expose show_in_nav_menus and show_ui for the post type response.

TODO: update related unit tests

Screen Shot 2021-02-12 at 2 30 38 PM

Screen Shot 2021-02-12 at 2 30 16 PM

@github-actions
Copy link

Hi @gwwar! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@gwwar
Copy link
Author

gwwar commented Feb 24, 2021

Going to close this draft out for now in favor of WordPress/gutenberg#29095

@gwwar gwwar closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant