Skip to content

Commit

Permalink
HTML API: Remove unused processor state context_node property
Browse files Browse the repository at this point in the history
The HTML Processor State `context_node` is redundant and can be deprecated. The property has been superseded by `WP_HTML_Processor->context_node` since [58304].

Props jonsurrell, gziolo.
Fixes #62518.




git-svn-id: https://develop.svn.wordpress.org/trunk@59463 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
gziolo committed Nov 27, 2024
1 parent 520e61d commit 6ed2409
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 14 deletions.
5 changes: 2 additions & 3 deletions src/wp-includes/html-api/class-wp-html-processor-state.php
Original file line number Diff line number Diff line change
Expand Up @@ -360,10 +360,9 @@ class WP_HTML_Processor_State {
* Context node initializing fragment parser, if created as a fragment parser.
*
* @since 6.4.0
* @deprecated 6.8.0 WP_HTML_Processor tracks the context_node internally.
*
* @see https://html.spec.whatwg.org/#concept-frag-parse-context
*
* @var [string, array]|null
* @var null
*/
public $context_node = null;

Expand Down
12 changes: 1 addition & 11 deletions src/wp-includes/html-api/class-wp-html-processor.php
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ public static function create_fragment( $html, $context = '<body>', $encoding =
}

$processor = new static( $html, self::CONSTRUCTOR_UNLOCK_CODE );
$processor->state->context_node = array( 'BODY', array() );
$processor->state->insertion_mode = WP_HTML_Processor_State::INSERTION_MODE_IN_BODY;
$processor->state->encoding = $encoding;
$processor->state->encoding_confidence = 'certain';
Expand All @@ -317,7 +316,7 @@ public static function create_fragment( $html, $context = '<body>', $encoding =

$context_node = new WP_HTML_Token(
'context-node',
$processor->state->context_node[0],
'BODY',
false
);

Expand Down Expand Up @@ -492,15 +491,6 @@ public function create_fragment_at_current_node( string $html ) {
$fragment_processor->context_node->bookmark_name = 'context-node';
$fragment_processor->context_node->on_destroy = null;

$fragment_processor->state->context_node = array( $fragment_processor->context_node->node_name, array() );

$attribute_names = $this->get_attribute_names_with_prefix( '' );
if ( null !== $attribute_names ) {
foreach ( $attribute_names as $name ) {
$fragment_processor->state->context_node[1][ $name ] = $this->get_attribute( $name );
}
}

$fragment_processor->breadcrumbs = array( 'HTML', $fragment_processor->context_node->node_name );

if ( 'TEMPLATE' === $fragment_processor->context_node->node_name ) {
Expand Down

0 comments on commit 6ed2409

Please sign in to comment.