Small tweaks based on feedback

WordPress · Dec 13, 2022 · 64c4621 · 64c4621
1 parent 8fa5d48
commit 64c4621
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/wp-includes/class-wp-theme-json.php b/src/wp-includes/class-wp-theme-json.php
@@ -2774,7 +2774,7 @@ protected static function remove_insecure_styles( $input ) {
 		foreach ( static::INDIRECT_PROPERTIES_METADATA as $property => $path ) {
 			$value = _wp_array_get( $input, $path, array() );
 			if (
-				isset( $value ) &&
+				null !== $value &&
 				! is_array( $value ) &&
 				static::is_safe_css_declaration( $property, $value )
 			) {

diff --git a/tests/phpunit/tests/theme/wpThemeJson.php b/tests/phpunit/tests/theme/wpThemeJson.php
@@ -2394,43 +2394,43 @@ public function test_remove_insecure_properties_should_allow_indirect_properties
 			array(
 				'version' => WP_Theme_JSON::LATEST_SCHEMA,
 				'styles'  => array(
+					'spacing' => array(
+						'blockGap' => '3em',
+					),
 					'blocks'  => array(
 						'core/social-links' => array(
 							'spacing' => array(
 								'blockGap' => array(
-									'top'  => '1em',
 									'left' => '2em',
+									'top'  => '1em',
 								),
 							),
 						),
 					),
-					'spacing' => array(
-						'blockGap' => '3em',
-					),
 				),
 			)
 		);
 
 		$expected = array(
 			'version' => WP_Theme_JSON::LATEST_SCHEMA,
 			'styles'  => array(
+				'spacing' => array(
+					'blockGap' => '3em',
+				),
 				'blocks'  => array(
 					'core/social-links' => array(
 						'spacing' => array(
 							'blockGap' => array(
-								'top'  => '1em',
 								'left' => '2em',
+								'top'  => '1em',
 							),
 						),
 					),
 				),
-				'spacing' => array(
-					'blockGap' => '3em',
-				),
 			),
 		);
 
-		$this->assertEqualSetsWithIndex( $expected, $actual );
+		$this->assertSameSetsWithIndex( $expected, $actual );
 	}
 
 	/**