Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured Event Data: Include the Event details on past years #1329

Open
wants to merge 3 commits into
base: production
Choose a base branch
from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented May 30, 2024

The code erroneously suggests that Scheduled should only be for future events, whereas the Scheduled state specifies:

https://schema.org/EventScheduled

The event is taking place or has taken place on the startDate as scheduled

Therefor, Scheduled in the past is valid and should not be interpreted by clients as a future event.

This may help with search engines determining the year of the content they're linking to.

See https://wordpress.slack.com/archives/C08M59V3P/p1717047874905299?thread_ts=1717000539.205949&cid=C08M59V3P

Screenshots

How to test the changes in this Pull Request:

dd32 added 3 commits May 30, 2024 15:48
The code erroneously suggests that Scheduled should only be for future events, whereas the Scheduled state specifies:

> The event is taking place or has taken place on the startDate as scheduled

Therefor, Scheduled in the past is valid and should not be interpreted by clients as a future event.

This may help with search engines determining the year of the content they're linking to.
The previous commit was too greedy, applying to events that were pre-schedule as well as closed.

This reverts it to instead add the closed state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant