Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Adding sans-serif and serif system fonts #667

Conversation

luminuu
Copy link
Member

@luminuu luminuu commented Oct 16, 2023

Description

This PR adds sans-serif and serif system fonts to the typography section. It has to be added to every style variation that changes the typography setup from the main theme.json.

A system font stack is a lightweight alternative to the provided fonts that the theme is designed with.

Alternative to #573, #590, #591.

Screenshots

CleanShot 2023-10-16 at 18 37 02@2x

Testing Instructions

  1. Check out PR
  2. Go to site editor
  3. Open any template
  4. Select some text
  5. Check typography / font family settings

Alternative:

  1. Go to global styles
  2. Open Typography section
  3. See the fonts listed as in the screenshot above

@luminuu
Copy link
Member Author

luminuu commented Oct 16, 2023

@richtabor I just merged in the latest updates for the style variations, please have a look!

@richtabor
Copy link
Member

@luminuu I had replaced sandstorm with "Ember" in #649. @beafialho, did you want to add it back?

styles/ice.json Show resolved Hide resolved
styles/sandstorm.json Outdated Show resolved Hide resolved
@richtabor richtabor force-pushed the 572-consider-adding-a-systemweb-safe-font-as-an-alternative-to-default-fonts branch from 181854c to 02bd50f Compare October 16, 2023 20:10
Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! love this

@richtabor richtabor merged commit 56ea500 into trunk Oct 16, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Consider adding a system/web safe font as an alternative to default fonts
3 participants