Removed themename in template parts #403
Conversation
There was a problem hiding this comment.
This is blocks at the moment.
The theme is currently required to include template parts within patterns, like we're doing in these two files. Otherwise they don't render:
Related: WordPress/gutenberg#53194 (comment)
|
I pinged @scruffian on this issue. I wonder, do the template parts still work with the theme slug present if the theme is installed in a subfolder/the folder has a different name than twentytwentyfour? |
|
WordPress/gutenberg#54595 has been merged and I would like to merge this by end of day today so it makes it to the first build in beta 1. This ensures that template parts will show no matter the folder your theme is installed in. Right now to test it we need to use the latest GB trunk. I've marked the PR for backport so it needs to make it to the final GB release before beta for this to work without the plugin installed. Lets test that this is working as intended. |
MaggieCabrera
force-pushed
the
remove-themename-in-template-part
branch
from
9587473
to
176efea
Compare
|
When is it best to merge this? @desrosj if I include this change on the first build of the theme at the current state, the template parts will fail. I'm assuming WordPress/gutenberg#54595 will get backported during Tuesday, so maybe it's best if we sit on this and add it to that build last minute? |
|
Let's proceed with the original PR and then create a follow up one for then. If there are any other changes that are ready, we can include them as well. |
MaggieCabrera
force-pushed
the
remove-themename-in-template-part
branch
from
176efea
to
7b302ab
Compare
|
We can bring this in now, I tested with core trunk and we don't need the theme slugs anymore |
Removed
"theme":"twentytwentyfour"in Template Parts as per guidelineFiles:
patterns/template-home-portfolio.php
patterns/template-home-writer.php