Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix/banner book desc heading #510

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

troychaplin
Copy link
Contributor

Description

Pattern uses an H3, creates incorrect heading level a11y error

Testing Instructions

  1. Add "Banner with book description" pattern to a page
  2. Check H2 is used

Copy link

github-actions bot commented Oct 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Oct 7, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan added Accessibility (a11y) Needs accessibility testing or feedback [Type] Bug An existing feature does not function as intended. labels Oct 7, 2024
@carolinan carolinan merged commit 5ac16ae into WordPress:trunk Oct 7, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility (a11y) Needs accessibility testing or feedback [Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants