Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Add buttons styles. #157

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Try: Add buttons styles. #157

merged 8 commits into from
Sep 4, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Aug 29, 2024

Description

Adding button styles according to the designs.

It works well in the default style. We will probably need to revisit the different variations once we have the section styles in.

Screenshots

Screen.Recording.2024-08-29.at.18.37.06.mov

Testing Instructions

  1. Create a page.
  2. Add a button with the default style and another one with outline.
  3. Confirm they're looking like the designs.

Copy link

github-actions bot commented Aug 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@beafialho
Copy link
Contributor

Design-wise this is looking great to me 👍

Happy to see both styles have the same height:

Captura de ecrã 2024-08-30, às 16 07 56

@carolinan carolinan merged commit c0311ec into trunk Sep 4, 2024
3 checks passed
@juanfra juanfra deleted the try/add-button-styles branch September 4, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants