Custom colors first pass #167
Conversation
Update from upstream
| /* Permalink - use to edit and share this gradient: http://colorzilla.com/gradient-editor/#000000+0,000000+100&0+0,0.3+100 */ | ||
| background: -moz-linear-gradient(top, rgba(255,255,255,0) 0%, rgba(255,255,255,0.3) 100%); /* FF3.6-15 */ | ||
| background: -webkit-linear-gradient(top, rgba(255,255,255,0) 0%,rgba(255,255,255,0.3) 100%); /* Chrome10-25,Safari5.1-6 */ | ||
| background: linear-gradient(to bottom, rgba(255,255,255,0) 0%,rgba(255,255,255,0.3) 100%); /* W3C, IE10+, FF16+, Chrome26+, Opera12+, Safari7+ */ |
There was a problem hiding this comment.
Expected single space after commas on the above 3 lines
There was a problem hiding this comment.
This is a direct copy/paste from style.css, but swapping out the colors; it will need to be updated there as well.
There was a problem hiding this comment.
Yup, #169 gets all the coding standards sorted for style.css
| /* Permalink - use to edit and share this gradient: http://colorzilla.com/gradient-editor/#000000+0,000000+100&0+0,0.3+75 */ | ||
| background: -moz-linear-gradient(top, rgba(255,255,255,0) 0%, rgba(255,255,255,0.3) 75%, rgba(255,255,255,0.3) 100%); /* FF3.6-15 */ | ||
| background: -webkit-linear-gradient(top, rgba(255,255,255,0) 0%,rgba(255,255,255,0.3) 75%,rgba(255,255,255,0.3) 100%); /* Chrome10-25,Safari5.1-6 */ | ||
| background: linear-gradient(to bottom, rgba(255,255,255,0) 0%,rgba(255,255,255,0.3) 75%,rgba(255,255,255,0.3) 100%); /* W3C, IE10+, FF16+, Chrome26+, Opera12+, Safari7+ */ |
There was a problem hiding this comment.
Expected single space after commas on the above 3 lines
Note that this was copied from style.css.
| function twentyseventeen_sanitize_colorscheme( $input ) { | ||
| $valid = array( 'light', 'dark', 'custom' ); | ||
|
|
||
| if ( array_key_exists( $input, $valid ) ) { |
There was a problem hiding this comment.
This should be in_array, since $valid is not a keyed array. Right now this doesn't save colorscheme.
|
The one remaining Travis CI failure is for line endings, which I'm unable to change from here. Someone will need to fix that on or after merge. This should be ready to go. After the initial merge, someone will need to go through and merge all changes to |
Per @melchoyce, switching #999 to #bbb. Assuming #aaa will need to go to #ccc in the process so that it doesn't become darker than the other pattern.
The base colorscheme doesn't specify this, so it wasn't being inverted but the text color was. Selectors copied from where the text color is inverted.
Adjust saturation to 50% per @melchoyce, and reduce the saturation on body text (base: WordPress#333) by 20% of the base saturation (should come out to 40%). Needs testing.
See #116.