Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Remove our Classic Block gallery shortcode editor styles #608

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Nov 15, 2018

As per my notes in #531 (comment)

These styles are broken right now, but they should be provided by Gutenberg — not the theme — in the first place.

Before:
screen shot 2018-11-15 at 4 02 51 pm

After:
screen shot 2018-11-15 at 4 03 11 pm
(^ This is how the [gallery] shortcode appears by default in the Classic Editor block)

These are broken right now, and they should ideally be provided by Gutenberg anyway.
@kjellr kjellr added the bug Something isn't working label Nov 15, 2018
@kjellr kjellr requested a review from allancole November 15, 2018 21:08
Copy link
Collaborator

@allancole allancole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that these styles should come from /core and/or Gutenberg similar to the previous editor which also provides built-in styles for gallery shortcodes in the editor

@allancole allancole merged commit 46da458 into master Nov 15, 2018
@kjellr kjellr deleted the update/classic-block-gallery-styles branch November 16, 2018 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants