This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Display comment times with default functions #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the lovely human_time_diff() with the get_comment_date() and get_comment_time() functions so that a user’s chosen time display settings are used in comments display.
|
Maybe remove |
Agreed. @briannaorg — once you remove that function, this'll be good to go. 👍 Thanks! |
Remove unused function.
|
All set! inc/template-tags.php has been updated, unused function has been removed & tested. |
|
Looks good! 👍Thanks @briannaorg |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #81.
Replace the lovely human_time_diff() with the get_comment_date() and
get_comment_time() functions so that a user’s chosen time display
settings are used in comments display.
If we end up building a project plugin for this (per the results of our dev tooling discussions) it would be great to add a setting in the Customizer that allows “human readable” time displays, to take advantage of the existing functions in template-tags.php.
WordPress.org username: technosiren