Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Use normal font-style for <em> when used inside a pullquote block #147

Merged
merged 6 commits into from
Oct 19, 2018

Conversation

audrasjb
Copy link

Hi,

As far as I know, when the text to be quoted itself contains italicized words, the classical typographic method consists in bringing out these words by returning to the normal font-style.

Fixes #63
See also my former PR: #100 (closed)
And @kjellr 's comment:

As noted in #63, block quotes aren't actually supposed to be italic by default. 🙂
wp-block-pullquote is italic by default though, and do require this update. @audrasjb, would you mind making this change only apply to .wp-block-pullquote?

Cheers,
Jb

audrasjb on w.org

@kjellr
Copy link
Collaborator

kjellr commented Oct 18, 2018

Thanks, @audrasjb. This is looking good on the front end:

screen shot 2018-10-18 at 7 49 55 am

Would you mind adding the style to style-editor.scss as well? Thanks!

@audrasjb
Copy link
Author

Hi @kjellr I added <em> styles in style-editor.scss

Works fine:
capture d ecran 2018-10-19 a 07 19 34

Cheers,
Jb

(audrasjb)

@kjellr
Copy link
Collaborator

kjellr commented Oct 19, 2018

Looks great! I just pulled in the latest updates from master, and fixed the style.css change that was causing a merge conflict. This one's good to go! Thanks @audrasjb.

@kjellr kjellr merged commit 4927b6e into WordPress:master Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blockquote paragraphs are italic
2 participants