Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Feature/min height emoji fix #106

Merged
merged 7 commits into from
Oct 19, 2018

Conversation

fabiankaegy
Copy link
Member

fixes issue mentioned in issue #105

@fabiankaegy
Copy link
Member Author

This fix introduces an error where in the admin avatar image also gets the min-height Banause of the specificity of the :not()selector. Working on a fix for that

@Michael-Ashfield
Copy link

I noticed you used unset, is this wise considering its poor browser support?
CanIUse mentions that IE doesn't support unset as-well as a few other browsers, with global support of 88%.
I would suggest trying auto as it is supported on all browsers.

https://caniuse.com/#search=unset

@LittleBigThing
Copy link

It should be min-height.

@fabiankaegy
Copy link
Member Author

@LittleBigThing thanks for noticing. Stupid mistake 😂

@kjellr
Copy link
Collaborator

kjellr commented Oct 18, 2018

@fabiankaegy did you try just removing the min-height entirely? I'm not 100% sure it's needed.

@allancole
Copy link
Collaborator

Yup, @fabiankaegy you can remove min-height entirely from the img selector—it’s unnecessary.

Take that out and we can go ahead and merge this PR ;-)

Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabiankaegy!

@kjellr kjellr merged commit e868037 into WordPress:master Oct 19, 2018
kjellr added a commit that referenced this pull request Oct 19, 2018
mmaumio added a commit to mmaumio/twentynineteen that referenced this pull request Oct 20, 2018
…into media_element_audio

* 'master' of https://github.com/WordPress/twentynineteen: (37 commits)
  Minor formatting fix, hide navigation menus
  Add @nielslange to contributors.md
  Replicate Gutenberg link hover behavior
  Add underline to links within comments.
  Use theme version as print style version number
  Adding styling for the comment form label(s)
  Replace border-bottom with text-decoration
  Add @audrasjb to CONTRIBUTORS.md
  Remove `twentynineteen_get_estimated_reading_time` following WordPress#168.
  Replace site title h1 tag with p when not on homepage.
  Adding compiled CSS from WordPress#106
  Fixes a fatal error that mysteriously slipped by Travis checks
  Add @khleomix to contributors.md
  remove rule for wp-config-sample and txt files
  Clear whitespace. Again.
  Fix formatting, make Travis happy
  Underline links within content
  Recompile SASS
  Add pullquote <em> font-style to style-editor CSS rules
  removed min-height entirely
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants