Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

gallery shortcode columns not working #91

Closed
joyously opened this issue Oct 17, 2018 · 9 comments
Closed

gallery shortcode columns not working #91

joyously opened this issue Oct 17, 2018 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@joyously
Copy link

There are styles for gallery shortcode columns, but it is incorrect.
For 1 column, the images are centered, but the captions are left. There is no space between images with no captions.
For 2 columns, 3 are shown.
For 3 columns, 2 are shown.
For 4 through 9 columns, it looks almost like 1 column, but the images are very far left on 4, a little more right on 5, more right on 6, etc., but all have just 1 image instead of 4, 5, 6, etc.

@briannaorg
Copy link
Contributor

I'm working on this one.

@kjellr kjellr assigned kjellr and unassigned kjellr Oct 17, 2018
@kjellr kjellr added the bug Something isn't working label Oct 17, 2018
@kjellr
Copy link
Collaborator

kjellr commented Oct 17, 2018

@joyously would you mind providing a screenshot here so we can get a better sense of the issue? Thanks!

briannaorg added a commit to briannaorg/twentynineteen that referenced this issue Oct 17, 2018
@briannaorg
Copy link
Contributor

I've submitted a fix for this - #130

@joyously
Copy link
Author

Here is what it looked like on my test site
gallery-test

allancole added a commit that referenced this issue Oct 19, 2018
Corrected column math in galleries - issue #91
@kjellr
Copy link
Collaborator

kjellr commented Oct 23, 2018

Fixed via 918a410

@kjellr kjellr closed this as completed Oct 23, 2018
@kjellr
Copy link
Collaborator

kjellr commented Oct 25, 2018

@allancole Now that I'm looking at this again, it's not looking fixed to me:

screen shot 2018-10-24 at 10 06 52 pm

(Using the theme unit test sample posts)

@briannaorg
Copy link
Contributor

briannaorg commented Oct 25, 2018

@kjellr @allancole I'm not sure how to duplicate the issue in the classic editor block to test, but for the theme unit display, _galleries.scss just needed the flex definition fleshed out a bit, so I created a PR (sorry, I know it's not assigned to me, it's just a quick fix on an issue I was already familiar with so I thought I'd pitch in).
screen shot 2018-10-24 at 10 08 56 pm

@kjellr
Copy link
Collaborator

kjellr commented Oct 26, 2018

Thank you, @briannaorg! The PR looks great — we really appreciate it! 🙌

@kjellr
Copy link
Collaborator

kjellr commented Nov 13, 2018

Closing this one in favor of the newer issue, #531.

@kjellr kjellr closed this as completed Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants