Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Post date using relative time #131

Closed
joyously opened this issue Oct 17, 2018 · 9 comments
Closed

Post date using relative time #131

joyously opened this issue Oct 17, 2018 · 9 comments
Labels
duplicate This issue or pull request already exists

Comments

@joyously
Copy link

The date on a post is shown in relative time (3 minutes) instead of the date format chosen by the user in Settings.

@kjellr
Copy link
Collaborator

kjellr commented Oct 17, 2018

Related to #81. Fix will likely be the same.

@kjellr kjellr added bug Something isn't working task and removed bug Something isn't working labels Oct 17, 2018
@fabiankaegy
Copy link
Member

I will take the issue 👍

@kjellr
Copy link
Collaborator

kjellr commented Oct 17, 2018

@fabiankaegy I think @briannaorg has this one actually, as per slack.

(Sorry for the confusion here. GitHub doesn't allow for assigning issues to people before they've issued their first commit in a repo, so it's not super-easy to "claim" these it turns out.)

@fabiankaegy
Copy link
Member

Oops 👍

@briannaorg
Copy link
Contributor

briannaorg commented Oct 17, 2018

@kjellr the date shown on posts is the estimated read time, not the post date. This is a theme feature, so this issue should be closed, but issue #81 should remain open.

@kjellr
Copy link
Collaborator

kjellr commented Oct 17, 2018

Ah! Good catch, thanks @briannaorg. I'm going to close this one in that case. 👍

@kjellr kjellr closed this as completed Oct 17, 2018
@joyously
Copy link
Author

joyously commented Oct 17, 2018

It should be labeled then. And the date should be shown somewhere.
Actually, if it's reading length, it should be removed, as that is plugin territory.

@briannaorg
Copy link
Contributor

briannaorg commented Oct 17, 2018

There's an existing twentynineteen_posted_on function to display post dates that's not being called in any template. There's no specific guideline for displaying post dates, so before I open an issue I'm going to review currently open issues and see if it's being discussed.

briannaorg added a commit to briannaorg/twentynineteen that referenced this issue Oct 18, 2018
As discussed in WordPress#131 and WordPress#166, adding post date display to entries
(replacing the estimated read time). Updated twentynineteen_posted_on()
to display watch icon SVG.
@designsimply
Copy link
Member

Note: the decision to remove reading time for now was made in #139 (comment) and @briannaorg is working on an update in #168.

@designsimply designsimply added duplicate This issue or pull request already exists and removed task labels Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants