Twenty Twenty One Blocks: Migrate Preformatted Block styles #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendezcode
changed the title
scruffian
reviewed
Nov 27, 2020
| overflow-x: auto; | ||
| white-space: pre !important; | ||
| font-size: var(--wp--preset--font-size--extra-small); |
There was a problem hiding this comment.
I think this could live in theme.json, once the block supports it. You can see how I did that for the code block: WordPress/gutenberg#27294
scruffian
reviewed
Nov 27, 2020
| pre.wp-block-preformatted { | ||
| overflow-x: auto; | ||
| white-space: pre; |
There was a problem hiding this comment.
I think these rules should be added to the Gutenburg block itself.
scruffian
requested changes
Nov 27, 2020
|
Based on the above I think we will end up with something similar to what you did for the code block... |
|
I have been trying to find the reason why the editor adds the |
… fix/migrate-preformatted-styles
|
Added a Gutenberg PR to take care of this one: WordPress/gutenberg#27584 |
|
I think we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add preformatted block styles, migrating applicable styles to theme.json
Broken out of #82
Fixes #96