Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add_theme_support required if tag exists #150

Closed
HardeepAsrani opened this issue Apr 30, 2016 · 2 comments
Closed

Make add_theme_support required if tag exists #150

HardeepAsrani opened this issue Apr 30, 2016 · 2 comments

Comments

@HardeepAsrani
Copy link
Contributor

Right now theme check shows the following error if the theme doesn't contain: add_theme_support( "post-thumbnails" );

RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.

That's fine for the some themes. But if a theme contains featured-images tag in its style.css file, then it should be required.

Same goes for post-formats, editor-style, custom-background, custom-header and a lot of tags.

Hope it's valid idea. :)

@grappler
Copy link
Member

Yes, we started the discussion at #128

@grappler
Copy link
Member

Looking at the code, it seems like an old check to see if the theme was using a custom solution for featured images. https://github.com/Otto42/theme-check/blob/master/checks/postthumb.php

I suppose we could remove this check now as it is not likely to come up. Post Thumbnails was introduced in WP 2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants