Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Tag functionality [Info] #128

Open
10 tasks
grappler opened this issue Mar 22, 2016 · 2 comments
Open
10 tasks

Theme Tag functionality [Info] #128

grappler opened this issue Mar 22, 2016 · 2 comments

Comments

@grappler
Copy link
Member

"The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design."

Add checks for

  • buddypress - I am not sure what the best check is here.
  • featured-images add_theme_support( 'post-thumbnails' );
  • custom-header add_theme_support( 'custom-header' );
  • custom-background add_theme_support( 'custom-background' );
  • custom-menu register_nav_menus()
  • editor-style add_editor_style()
  • flexible-header "Uses ‘flex-height’ and/or ‘flex-width’ parameter of add_theme_support( 'custom-header' );"
  • post-formats add_theme_support( 'post-formats' );
  • theme-options add_action( 'customize_register' );
  • threaded-comments wp_enqueue_script( 'comment-reply' );
@ernilambar
Copy link
Member

Some more:

  • translation-ready - load_theme_textdomain or load_child_theme_textdomain
  • rtl-language-support - Check for rtl.css
  • featured-image-header - This requires add_theme_support( 'post-thumbnails' ) and add_theme_support( 'custom-header' )

@grappler
Copy link
Member Author

Those are good for info checks but they require manual checks to see if all of the strings are internationalized and that the rtl.css is not empty.

I agree that featured-image-header requires add_theme_support( 'post-thumbnails' ) but not add_theme_support( 'custom-header' ) . The theme author just needs to output the featured image in the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants