Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for failures AND errors #84

Merged
merged 1 commit into from
Sep 11, 2020
Merged

check for failures AND errors #84

merged 1 commit into from
Sep 11, 2020

Conversation

pfefferle
Copy link
Member

otherwise the result is empty for errors.

See: https://gist.github.com/pfefferle/69e9cc0451fce28125334f8d09713c8d for some test data

@pfefferle pfefferle requested review from getsource and a team July 17, 2020 12:38
@pfefferle pfefferle changed the title check if for failures AND errors check for failures AND errors Jul 19, 2020
getsource
getsource approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@getsource getsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to test. This looks good to me!

@pfefferle pfefferle merged commit 6a9951a into master Sep 11, 2020
@pfefferle pfefferle deleted the fix-error-reports branch September 11, 2020 18:58
@pfefferle
Copy link
Member Author

thanks @getsource :)

@getsource getsource mentioned this pull request Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getsource getsource getsource approved these changes

@danielbachhuber danielbachhuber Awaiting requested review from danielbachhuber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfefferle @getsource