GitHub workflow to build and deploy standalone plugins #686
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: Deploy standalone plugins to WordPress.org | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - trunk | ||
| - 'release/**' | ||
| paths: | ||
| - '.github/workflows/deploy-standalone-plugins.yml' | ||
| pull_request: | ||
| branches: | ||
| - trunk | ||
| - 'release/**' | ||
| - 'feature/**' | ||
| paths: | ||
| - '.github/workflows/deploy-standalone-plugins.yml' | ||
| types: | ||
| - opened | ||
| - reopened | ||
| - synchronize | ||
|
|
||
| jobs: | ||
| release: | ||
| name: New Release | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| matrix: ${{ steps.set-matrix.outputs.matrix }} | ||
| steps: | ||
mukeshpanchal27 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - uses: actions/checkout@v3 | ||
| - id: set-matrix | ||
| run: echo "matrix="$(jq -c '{include:[keys[] as $k | {name:$k,slug:.[$k].slug,version:.[$k].version }]}' plugins.json) >> $GITHUB_OUTPUT | ||
mukeshpanchal27 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - uses: actions/checkout@v3 | ||
| - name: Setup Node.js (.nvmrc) | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: npm | ||
| - name: npm install | ||
| run: npm ci | ||
| - name: Building standalone plugins | ||
| id: build-plugins | ||
| run: npm run build-plugins | ||
| deploy: | ||
| needs: release | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: ${{ fromJSON(needs.release.outputs.matrix) }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Deploy Standalone Plugin - ${{ matrix.slug }} | ||
| uses: 10up/action-wordpress-plugin-deploy@stable | ||
| env: | ||
| #SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }} | ||
| #SVN_USERNAME: ${{ secrets.SVN_USERNAME }} | ||
| SVN_PASSWORD: SVN_PASSWORD | ||
| SVN_USERNAME: SVN_USERNAME | ||
|
There was a problem hiding this comment. Why are these two lines commented out? There was a problem hiding this comment. Because if somehow the workflow starts working, then it will not commit the code in SVN because of wrong access. I'll update it once everything is finalised. Thanks. |
||
| SLUG: ${{ matrix.slug }} | ||
| VERSION: ${{ matrix.version }} | ||
| BUILD_DIR: ./build/${{ matrix.slug }} | ||
mukeshpanchal27 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you have these here for testing, but I think we'll need to change this trigger to something different like a release, or the addition of a tag, or something. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense.
Performance Lab uses:
WordPress Beta Tester uses:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @joemcgill, Once we have thoroughly tested the workflow, we must update it with a
releaseor pushtags.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Can you please add both versions of the code here so that we can proceed with the full code review? You can comment out the version which we should eventually use (on release or manual dispatch), and then add a
TODOcomment to get rid of the current triggers here before we merge this.