Add ReturnTypeWillChange attribute for offsetGet to suppress notice #1607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a deprecation warning after #1585:
This adds
#[ReturnTypeWillChange]
attribute as suggested.This is also used in core, for example: https://github.com/WordPress/wordpress-develop/blob/de51a4412dc3fa4d2591c59492fa76227cdddd29/src/wp-includes/class-wp-block-list.php#L81-L92