-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse WP_HTML_Processor::is_void()
now that WP 6.5 is minimum supported version
#1115
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6063786
to
34b6a27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @westonruter!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter Actually, it looks like https://github.com/WordPress/performance/actions/runs/8583685696/job/23573872147?pr=1115 has failures related to this change. Can you check?
01972c9
to
d4611a6
Compare
d4611a6
to
0f350c4
Compare
@felixarntz Ah, this may have been an oversight in core that certain void tags were missed. I've opened Core-60961 to discuss that. In the meantime, probably better to let this PR sit. |
@westonruter SG. We should probably set the base to |
This reverts commit 0f350c4.
Oh, and actually |
WP_HTML_Processor::is_void()
now that WP 6.4 is minimum supported versionWP_HTML_Processor::is_void()
now that WP 6.5 is minimum supported version
This was done in #1333. |
This removes a TODO to reuse
WP_HTML_Processor::is_void()
instead of replicating that functionality which was not available until WP 6.4. Now that 6.4 is the minimum-supported version, that method can be reused.This could have been done previously in #1068 when the minimum version was bumped.